[DO NOT SUBMIT] Verify new strings can be added to material_ui and cupertino_ui#2
Closed
QuncCccccc wants to merge 31 commits into
Closed
Conversation
Moved from flutter_localizations and should be working minus an import from cupertino_ui that I'll work on next.
Moved into cupertino_ui similar to how it was done in material_ui. Both are now usable.
These were copied from the l10 folder of flutter_localizations and then modified.
In the previous iteration of this PR, this was done just by copying the code without history. I anticipate conflicts because of this when I cherry pick those commits.
The problem was that I copied in a newer change (flutter/flutter#188473) when I copied in the localizations stuff. So I got the test changes from that PR, but not the code change to make the tests pass. In the future, this PR will come in when we upgrade the SDK for material_ui and cupertino_ui.
Owner
|
Thanks for testing this! |
justinmc
force-pushed
the
flutter_localizations
branch
from
July 14, 2026 18:22
d8a1442 to
43a4d61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only used for verification for new string additions in MaterialLocalizations and CupertinoLocalizations.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2