-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: Im not absolute feeling relative today #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Building is failing due to conflict of Bundler version in the 3.8.5 container and the project's own configuration. There is no 3.9 container is seems. And 4 might work - if this project is setup to work correctly 3 and 4. In particular, using |
|
@MichaelCurrin you cannot just approve some pr, for any repo you don't control. |
|
The code looked good and I want this fix on my site, so just wanted to move this along. The PR is still blocked from merging until an admin user reviews it, so there is no risk of this being merged after my review alone. |
That might be true, but I misunderstood that you would be able to merge this. I never seen a "review" from a user that doesn't have contributor access to the repo. |
|
Okay thanks for clarifying. The way GH perms works is that even when an admin user does approve this, only admins can ever have access to the merge button. |
Following just-the-docs#544: - Replace `absolute_url` by `relative_url`.
|
Also running into this! Would love to see this PR merged, thanks for your consideration. |
|
Currently running this fork so that search works, using GitHub pages. |
|
I have no idea how the merging for this repo works. Closing this pr, and moved on to my own fork. |
Replace all uses of `absolute_url` by `relative_url`. Co-authored-by: Stephan van Rooij <[email protected]> @svrooij I hope this finally fixes issue just-the-docs#543, and subsumes your closed just-the-docs#544. I used `Find in Project` (in Atom) to replace all 11 occurrences of `absolute_url`.
@svrooij I hope this finally fixes issue just-the-docs#543, and subsumes your closed just-the-docs#544. I used `Find in Project` (in Atom) to replace all 11 occurrences of `absolute_url`.
Extension of PR just-the-docs#977 to v0.4.0.rc1: - Make callouts `loud`. - Replace a warning paragraph by a callout. - Use a reference link instead of an explicit url for @pmarsceill . - Add link reference definitions for PRs and new contributors in v0.4.0.rc1. - Replace inline urls by shortcut link references. The changes to replace URLs by link references would be too tedious and error-prone to do completely manually for v0.4.0.rc1. The following regexp replacements were applied to the sections of v0.4.0.rc1, using Atom: - Copy a section of changes. - In the copy, replace `.*(https://.*pull/)([0-9]+).*$` by `[#$2]: $1$2`. - In the original, replace `(https://.*pull/)([0-9]+)` by `[#$2]`. - Copy a section of new contributors. - In the copy, replace `\* @([^ ]+) .*$` by `[@$1]: https://githhub.com/$1`. - In the original, replace `@([a-zA-Z0-9]+)` by `[@$1]`. Add (co)authors in [just-the-docs#578]: * [@AdityaTiwari2102] made their first contribution in [just-the-docs#477] * [@svrooij] made their first contribution in [just-the-docs#544] [@AdityaTiwari2102]: https://githhub.com/AdityaTiwari2102 [@svrooij]: https://githhub.com/svrooij To test: 1. Check that the CHANGELOG contents looks the same in the docs and in the repo (apart from the callouts) with clickable links to all PRs and contributors for v0.4.0.rc1. 2. Check that none of the lines with changes or new contributors have been removed.
* Make more CHANGELOG urls clickable Extension of PR #977 to v0.4.0.rc1: - Make callouts `loud`. - Replace a warning paragraph by a callout. - Use a reference link instead of an explicit url for @pmarsceill . - Add link reference definitions for PRs and new contributors in v0.4.0.rc1. - Replace inline urls by shortcut link references. The changes to replace URLs by link references would be too tedious and error-prone to do completely manually for v0.4.0.rc1. The following regexp replacements were applied to the sections of v0.4.0.rc1, using Atom: - Copy a section of changes. - In the copy, replace `.*(https://.*pull/)([0-9]+).*$` by `[#$2]: $1$2`. - In the original, replace `(https://.*pull/)([0-9]+)` by `[#$2]`. - Copy a section of new contributors. - In the copy, replace `\* @([^ ]+) .*$` by `[@$1]: https://githhub.com/$1`. - In the original, replace `@([a-zA-Z0-9]+)` by `[@$1]`. Add (co)authors in [#578]: * [@AdityaTiwari2102] made their first contribution in [#477] * [@svrooij] made their first contribution in [#544] [@AdityaTiwari2102]: https://githhub.com/AdityaTiwari2102 [@svrooij]: https://githhub.com/svrooij To test: 1. Check that the CHANGELOG contents looks the same in the docs and in the repo (apart from the callouts) with clickable links to all PRs and contributors for v0.4.0.rc1. 2. Check that none of the lines with changes or new contributors have been removed. * Revert to quiet callouts
This PR replaces all occurences of
| absolute_urlwith| relative_url. This fixes a lot of issues when you're doing a multi deploy and is closer to the default Jekyll experience.Fixed #543