Skip to content

Conversation

@svrooij
Copy link

@svrooij svrooij commented Jan 19, 2021

This PR replaces all occurences of | absolute_url with | relative_url. This fixes a lot of issues when you're doing a multi deploy and is closer to the default Jekyll experience.

Fixed #543

@MichaelCurrin
Copy link

MichaelCurrin commented Apr 2, 2021

Building is failing due to conflict of Bundler version in the 3.8.5 container and the project's own configuration.

There is no 3.9 container is seems. And 4 might work - if this project is setup to work correctly 3 and 4. In particular, using link tag applies a subpath in Jekyll 4. But using relative_url filter works the same in 3 and 4.

@svrooij
Copy link
Author

svrooij commented Apr 2, 2021

@MichaelCurrin you cannot just approve some pr, for any repo you don't control.

@MichaelCurrin
Copy link

The code looked good and I want this fix on my site, so just wanted to move this along.

The PR is still blocked from merging until an admin user reviews it, so there is no risk of this being merged after my review alone.

@svrooij
Copy link
Author

svrooij commented Apr 2, 2021

The code looked good and I want this fix on my site, so just wanted to move this along.

The PR is still blocked from merging until an admin user reviews it, so there is no risk of this being merged after my review alone.

That might be true, but I misunderstood that you would be able to merge this. I never seen a "review" from a user that doesn't have contributor access to the repo.

@MichaelCurrin
Copy link

Okay thanks for clarifying.

The way GH perms works is that even when an admin user does approve this, only admins can ever have access to the merge button.

pdmosses added a commit to pdmosses/just-the-docs that referenced this pull request Apr 16, 2021
Following just-the-docs#544:
- Replace `absolute_url` by `relative_url`.
@dinamlev
Copy link

dinamlev commented Aug 23, 2021

Also running into this! Would love to see this PR merged, thanks for your consideration.

@FranciscoKnebel
Copy link

Currently running this fork so that search works, using GitHub pages.
Temp fix while this is not merged is inserting in _config.yml:

remote_theme: svrooij/just-the-docs@relative-everything

@pdmosses pdmosses mentioned this pull request Apr 20, 2022
@svrooij
Copy link
Author

svrooij commented May 30, 2022

I have no idea how the merging for this repo works. Closing this pr, and moved on to my own fork.

@svrooij svrooij closed this May 30, 2022
pdmosses added a commit to pdmosses/just-the-docs that referenced this pull request Jun 27, 2022
Replace all uses of `absolute_url` by `relative_url`.

Co-authored-by: Stephan van Rooij <[email protected]>

@svrooij I hope this finally fixes issue just-the-docs#543, and subsumes your closed just-the-docs#544. I used `Find in Project` (in Atom) to replace all 11 occurrences of `absolute_url`.
pdmosses added a commit to pdmosses/just-the-docs that referenced this pull request Aug 4, 2022
simonebortolin added a commit to simonebortolin/just-the-docs that referenced this pull request Aug 6, 2022
@svrooij I hope this finally fixes issue just-the-docs#543, and subsumes your closed just-the-docs#544. I used `Find in Project` (in Atom) to replace all 11 occurrences of `absolute_url`.
mattxwang pushed a commit that referenced this pull request Aug 8, 2022
pdmosses added a commit to pdmosses/just-the-docs that referenced this pull request Sep 24, 2022
Extension of PR just-the-docs#977 to v0.4.0.rc1:

- Make callouts `loud`.
- Replace a warning paragraph by a callout.
- Use a reference link instead of an explicit url for @pmarsceill .
- Add link reference definitions for PRs and new contributors in v0.4.0.rc1.
- Replace inline urls by shortcut link references.

The changes to replace URLs by link references would be too tedious and error-prone to do completely manually for v0.4.0.rc1.
The following regexp replacements were applied to the sections of v0.4.0.rc1, using Atom:

- Copy a section of changes.
- In the copy, replace `.*(https://.*pull/)([0-9]+).*$` by `[#$2]: $1$2`.
- In the original, replace `(https://.*pull/)([0-9]+)` by `[#$2]`.

- Copy a section of new contributors.
- In the copy, replace `\* @([^ ]+) .*$` by `[@$1]: https://githhub.com/$1`.
- In the original, replace `@([a-zA-Z0-9]+)` by `[@$1]`.

Add (co)authors in [just-the-docs#578]:

* [@AdityaTiwari2102] made their first contribution in [just-the-docs#477]
* [@svrooij] made their first contribution in [just-the-docs#544]

[@AdityaTiwari2102]: https://githhub.com/AdityaTiwari2102
[@svrooij]: https://githhub.com/svrooij

To test:

1. Check that the CHANGELOG contents looks the same in the docs and in the repo (apart from the callouts) with clickable links to all PRs and contributors for v0.4.0.rc1.

2. Check that none of the lines with changes or new contributors have been removed.
mattxwang pushed a commit that referenced this pull request Sep 26, 2022
* Make more CHANGELOG  urls clickable

Extension of PR #977 to v0.4.0.rc1:

- Make callouts `loud`.
- Replace a warning paragraph by a callout.
- Use a reference link instead of an explicit url for @pmarsceill .
- Add link reference definitions for PRs and new contributors in v0.4.0.rc1.
- Replace inline urls by shortcut link references.

The changes to replace URLs by link references would be too tedious and error-prone to do completely manually for v0.4.0.rc1.
The following regexp replacements were applied to the sections of v0.4.0.rc1, using Atom:

- Copy a section of changes.
- In the copy, replace `.*(https://.*pull/)([0-9]+).*$` by `[#$2]: $1$2`.
- In the original, replace `(https://.*pull/)([0-9]+)` by `[#$2]`.

- Copy a section of new contributors.
- In the copy, replace `\* @([^ ]+) .*$` by `[@$1]: https://githhub.com/$1`.
- In the original, replace `@([a-zA-Z0-9]+)` by `[@$1]`.

Add (co)authors in [#578]:

* [@AdityaTiwari2102] made their first contribution in [#477]
* [@svrooij] made their first contribution in [#544]

[@AdityaTiwari2102]: https://githhub.com/AdityaTiwari2102
[@svrooij]: https://githhub.com/svrooij

To test:

1. Check that the CHANGELOG contents looks the same in the docs and in the repo (apart from the callouts) with clickable links to all PRs and contributors for v0.4.0.rc1.

2. Check that none of the lines with changes or new contributors have been removed.

* Revert to quiet callouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Absolute url vs relative url

5 participants