Skip to content

Conversation

@pdmosses
Copy link
Contributor

Fix #491

Fix just-the-docs#491
- Restrict an `li` style to direct descendants.
- Add the examples from just-the-docs#491 to the regression tests
- Add a test for 6 levels of nested ordered list.
- Replace the test for 6 levels or ordered list by a test checking the couoters for 3 levels.
@pdmosses pdmosses requested a review from pmarsceill November 23, 2020 09:09
@pdmosses pdmosses mentioned this pull request Feb 22, 2021
mattxwang added a commit that referenced this pull request Jul 4, 2022
This PR combines (and resolves conflicts between) #448, #463, #466, #494, #495, #496, #498, and #572. 

The main aim is to facilitate use of several of the implemented features _together_, when using the fork as a remote theme. It should also simplify merging the included PRs into a future release.

The branch [combination-rec-nav](https://github.com/pdmosses/just-the-docs/tree/combination-rec-nav) adds [multi-level navigation](#462) and (NEW:) [sibling links](#394) to the branch used for this PR. It includes updated [documentation for the navigation structure](https://pdmosses.github.io/just-the-docs/docs/navigation-structure/), and reorganised and extended [navigation tests](https://pdmosses.github.io/just-the-docs/tests/navigation/). The documentation and the tests can be browsed at the (temporary) [website published from the combination-rec-nav branch](https://pdmosses.github.io/just-the-docs/).

_Caveat:_ The changes to v0.3.3 in this PR and #462 have not yet been reviewed or approved, and may need updating before merging into a release of the theme. If you use a branch from a PR as a remote theme, there is a risk of such updates affecting your website. Moreover, these branches are likely to be deleted after they have been merged. To avoid  such problems, you could copy the branch that you want to use to your own fork of the theme.

Co-authored-by: Matt Wang <[email protected]>
@mattxwang
Copy link
Member

Going to close as we've merged in #578; @pdmosses feel free to reopen if necessary!

@pdmosses
Copy link
Contributor Author

pdmosses commented Nov 3, 2022

As this PR was merged in a pre-release of v0.4.0, I'm deleting the PR branch. Let me know if you're still using it, and none of the pre-releases of v0.4.0 works for you.

@pdmosses pdmosses deleted the nested-lists branch November 3, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unordered lists that are at least 2 deep in a nest with ordered lists 'inherit' the ordering from their parent

2 participants