Repository navigation
Fix stuck Codex working indicator by steering busy messages - #552
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending another message while Codex was working opened an overlapping ACP prompt. Older requests could remain unanswered after Codex finished, leaving the panel stuck on “Codex is working…”. Busy sends now use steering when the agent advertises steering without a prompt queue; queue-capable agents retain their existing behavior.
Keep codex-acp 1.10.0 / Codex 0.153.3 and use Nix
fetchpatchto backport upstream PR #441, pinned to its commit and content hash. If a turn finishes before steering arrives, the adapter returns the message to Olai to start a tracked prompt. The upstream PR remains open; its branch is based on an older adapter release.Browser coverage exercises multiple busy sends, completion, cancellation, refused-steering retry, and completion/cancellation races. Chat documentation is updated.
Validation:
just cipassed on274a7f483: 49 successful jobs, including all 1,485 browser scenarios.