[v4] Fix Qt5_DIR environment variable#190
Merged
jurplel merged 5 commits intojurplel:masterfrom May 13, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #184.
This adds the
QT_ROOT_DIRenvironment variable that takes the place of the oldQt5_DIRandQt6_DIRvariables, and pointsQt5_DIRto the location that CMake expects.Breaking changes are documented in the
README_upgrade_guide.mdfile.Please be aware that this is not a bug fix. I added a
CMakeLists.txtfile to the test project, so that each test run can configure a test project with CMake; these tests were passing before I made any code changes. The changes here are meant to make the action easier for users to understand:Qt5_DIRis now given the value that it would need to have to run CMake properly, if the qmake directory had not been added to the path.Qt5_DirandQt6_DIRvariables have been removed, since they have no intrinsic purpose other than to preserve the legacy interface. Removing them makes the code easier to maintain and the environment easier to understand.This PR should not be merged into v3 of this action, owing to breaking changes.