Skip to content

Revert "Add handling for no ref being provided"#130

Merged
choldgraf merged 1 commit intomasterfrom
revert-128-fix-clone-depth
Nov 1, 2017
Merged

Revert "Add handling for no ref being provided"#130
choldgraf merged 1 commit intomasterfrom
revert-128-fix-clone-depth

Conversation

@yuvipanda
Copy link
Copy Markdown
Collaborator

Reverts #128

It looks like shallow clones are a lot more hairy than we realized.
We discovered the following:

  1. We currently have no way to figure out if a clone is shallow or not.
    An option has been added to rev-parse (why rev-parse?!) but that's
    too new and not in any packaged git.
  2. If your repo has under 50 commits, it will not be shallow!
  3. If you try to run git fetch --unshallow on a non-shallow repo it is a fatal error

@choldgraf choldgraf merged commit 4f6501e into master Nov 1, 2017
@yuvipanda
Copy link
Copy Markdown
Collaborator Author

Second part of the revert will be part of #120

@minrk minrk deleted the revert-128-fix-clone-depth branch December 1, 2018 20:48
markmo pushed a commit to markmo/repo2docker that referenced this pull request Jan 22, 2021
…epth

Revert "Add handling for no ref being provided"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants