Repository navigation
Conversation
The symlink() test helper calls os.symlink unconditionally, so test_bad_symlink and test_good_symlink error in setup on Windows without elevation or Developer Mode (WinError 1314). CI stays green because the windows-latest runner can create symlinks. Guard the helper with pytest.skip on OSError, matching the try/except capability check already used in test_fileio.py. The tests still run wherever symlinks can be created. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/services/contents/test_manager.py::test_bad_symlinkand::test_good_symlinkerror in setup on Windows without elevation or Developer Mode:
Both go through the module's
symlink()helper, which callsos.symlink()unconditionally. CI stays green because the
windows-latestrunner can createsymlinks, so the failure is invisible in CI and only hits an unprivileged Windows
contributor's local run. (
test_recursive_symlinkis alreadyskipif(win), for anunrelated reason.)
Fix
Guard the
symlink()helper withpytest.skiponOSError, matching thetry/exceptcapability check already used intest_fileio.py. The tests still runeverywhere symlinks can be created (Linux, macOS, and elevated / Developer-Mode
Windows) — only the unprivileged-Windows case is skipped instead of erroring.
Note
Verified with
py_compileand by inspection; the change is atry/exceptthat onlyactivates when
os.symlinkraises, so it can't affect the passing path. I don't havean unprivileged-Windows CI runner to exercise the skip, so a maintainer confirming it
there would be welcome.
🤖 Generated with Claude Code