Skip to content

Fix deprecation warning when importing from jsonschema#368

Merged
blink1073 merged 3 commits into
jupyter:mainfrom
eladkal:deprecation
Jul 7, 2023
Merged

Fix deprecation warning when importing from jsonschema#368
blink1073 merged 3 commits into
jupyter:mainfrom
eladkal:deprecation

Conversation

@eladkal

@eladkal eladkal commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

jsonschema v4.18.0 deprecated
importing of jsonschema.ErrorTree
instead import it via jsonschema.exceptions.ErrorTree

https://github.com/python-jsonschema/jsonschema/releases/tag/v4.18.0

This to avoid warning raised:

 /usr/local/lib/python3.8/site-packages/nbformat/json_compat.py:14:Importing ErrorTree directly from the jsonschema package is deprecated and will become an ImportError. Import it from jsonschema.exceptions instead.
/usr/local/lib/python3.8/site-packages/nbformat/json_compat.py:14:Importing ErrorTree directly from the jsonschema package is deprecated and will become an ImportError. Import it from jsonschema.exceptions instead.

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
blink1073 enabled auto-merge (squash) July 7, 2023 18:11
@blink1073
blink1073 disabled auto-merge July 7, 2023 18:14
@blink1073
blink1073 enabled auto-merge (squash) July 7, 2023 18:14
@blink1073

Copy link
Copy Markdown
Contributor

I'll cut a release with this early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants