Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jupyter/nbconvert
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cefe0bf
Choose a base ref
...
head repository: jupyter/nbconvert
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b645841
Choose a head ref
  • 13 commits
  • 16 files changed
  • 9 contributors

Commits on Nov 14, 2021

  1. Improve the speed of valdiation (#1672)

    Motivation:
      - We are looking to build out a notebook viewer with an eye toward performance.
        In our flamegraph research we found that as much as 90% of the time spent in
        Notebook creation can occur in the preprocessor valdiation logic. This pr
        introduces the optional idea of optimistic validation, in which we care not
        about which preprocessor introduces a validation error but that the notebook
        ends in a valid state, since we care more about speed.
    
    Related Issues:
      - #1663
    
    Changes:
      - Introduces a config option to remove some of the validation checks.
    
    Questions:
      - I am new to the project and am not sure where a test should live for
        this logic, or the best way to structure such a test. If a reference
        is available I will happily added a test.
    gwincr11 authored Nov 14, 2021
    Configuration menu
    Copy the full SHA
    e6eb9f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    bc9802c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Allow passing extra args to code highlighter (#1683)

    I primarily want to allow for the possibility of line numbers
    in HTML output. Pygments supports this natively, but we don't
    have a way to pass arguments through to pygments.
    
    A traitlet is added to allow passing arbitrary extra args
    to the Pygments formatter, for Html and LaTeX. Should allow for
    line number control and much more :)
    
    This has been something folks have asked for for a while.
    
    Ref ipython/ipython#5847
    Ref #427
    Ref yuvipanda/notebooksharing.space#34
    yuvipanda authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    9c1dcfc View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Configuration menu
    Copy the full SHA
    e5d0cfd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c8d9c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Fix recent pandoc latex tables (#1536, #1566) (#1686)

    Pandoc >= 2.11.1 requires the calc package, and pandoc >= 2.11.3
    requires the array package, for larger tables (taken from git blame
    for pandoc's templates).  This commits adds the two packages in
    an order similar to that in pandoc's templates.
    cgevans authored Dec 9, 2021
    Configuration menu
    Copy the full SHA
    b9addb2 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Add an invalid notebook error (#1675)

    * Add an invalid notebook error
    Motivation:
      - As we are now service hundreds of thousands of notebooks a day, we are
        seeing a number of errors from Notebook rendering that really stem
        from notebooks not being properly formated. These show up in a number
        of errors such as the error handled in this pr, an assertion error,
        we have also seen key errors and others. This pr is a bit of a proposal
        to instead introduced a common exception that indicates the notebook
        is missing some required data that is needed to render itself.
    
    * Update nbconvert/filters/markdown_mistune.py
    
    Co-authored-by: Matthias Bussonnier <[email protected]>
    
    Co-authored-by: Matthias Bussonnier <[email protected]>
    gwincr11 and Carreau authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    88ee3d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Configuration menu
    Copy the full SHA
    cf7c532 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fe7c81 View commit details
    Browse the repository at this point in the history
  3. Fix use of deprecated API and update test matrix (#1696)

    * fix use of deprecated API and add python 3.10 test
    
    * test on pypy
    
    * fix syntax
    
    * clean up pypy
    
    * expand test matrix
    
    * cleanup
    
    * cleanup
    
    * fix install
    
    * fix windows test
    
    * fix windows test
    
    * fix windows test
    
    * fix windows test
    
    * fix windows test
    
    * fix excludes
    
    * fix tests on py310
    
    * cleanup
    
    * cleanup
    blink1073 authored Dec 28, 2021
    Configuration menu
    Copy the full SHA
    708b217 View commit details
    Browse the repository at this point in the history
  4. Update nbconvert_library.ipynb (#1695)

    The generated html file was not following the 'classic' template, but instead 'lab', when I ran the code according to documentaion. But when I passed the template_name as a keyword arguement to HTMLExporter it worked. So I made necessary changes to the code, in a way which worked for me. Please do a review of the code and accept the changes
    aswin4400-ops authored Dec 28, 2021
    Configuration menu
    Copy the full SHA
    45df4b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Configuration menu
    Copy the full SHA
    fc32d73 View commit details
    Browse the repository at this point in the history
  2. Release 6.4.0

    blink1073 committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b645841 View commit details
    Browse the repository at this point in the history
Loading