-
Notifications
You must be signed in to change notification settings - Fork 609
Comparing changes
Open a pull request
base repository: jupyter/nbconvert
base: cefe0bf
head repository: jupyter/nbconvert
compare: b645841
- 13 commits
- 16 files changed
- 9 contributors
Commits on Nov 14, 2021
-
Improve the speed of valdiation (#1672)
Motivation: - We are looking to build out a notebook viewer with an eye toward performance. In our flamegraph research we found that as much as 90% of the time spent in Notebook creation can occur in the preprocessor valdiation logic. This pr introduces the optional idea of optimistic validation, in which we care not about which preprocessor introduces a validation error but that the notebook ends in a valid state, since we care more about speed. Related Issues: - #1663 Changes: - Introduces a config option to remove some of the validation checks. Questions: - I am new to the project and am not sure where a test should live for this logic, or the best way to structure such a test. If a reference is available I will happily added a test.Configuration menu - View commit details
-
Copy full SHA for e6eb9f7 - Browse repository at this point
Copy the full SHA e6eb9f7View commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bc9802c - Browse repository at this point
Copy the full SHA bc9802cView commit details
Commits on Dec 2, 2021
-
Allow passing extra args to code highlighter (#1683)
I primarily want to allow for the possibility of line numbers in HTML output. Pygments supports this natively, but we don't have a way to pass arguments through to pygments. A traitlet is added to allow passing arbitrary extra args to the Pygments formatter, for Html and LaTeX. Should allow for line number control and much more :) This has been something folks have asked for for a while. Ref ipython/ipython#5847 Ref #427 Ref yuvipanda/notebooksharing.space#34
Configuration menu - View commit details
-
Copy full SHA for 9c1dcfc - Browse repository at this point
Copy the full SHA 9c1dcfcView commit details
Commits on Dec 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e5d0cfd - Browse repository at this point
Copy the full SHA e5d0cfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8d9c8 - Browse repository at this point
Copy the full SHA 6c8d9c8View commit details
Commits on Dec 9, 2021
-
Fix recent pandoc latex tables (#1536, #1566) (#1686)
Pandoc >= 2.11.1 requires the calc package, and pandoc >= 2.11.3 requires the array package, for larger tables (taken from git blame for pandoc's templates). This commits adds the two packages in an order similar to that in pandoc's templates.
Configuration menu - View commit details
-
Copy full SHA for b9addb2 - Browse repository at this point
Copy the full SHA b9addb2View commit details
Commits on Dec 10, 2021
-
Add an invalid notebook error (#1675)
* Add an invalid notebook error Motivation: - As we are now service hundreds of thousands of notebooks a day, we are seeing a number of errors from Notebook rendering that really stem from notebooks not being properly formated. These show up in a number of errors such as the error handled in this pr, an assertion error, we have also seen key errors and others. This pr is a bit of a proposal to instead introduced a common exception that indicates the notebook is missing some required data that is needed to render itself. * Update nbconvert/filters/markdown_mistune.py Co-authored-by: Matthias Bussonnier <[email protected]> Co-authored-by: Matthias Bussonnier <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 88ee3d3 - Browse repository at this point
Copy the full SHA 88ee3d3View commit details
Commits on Dec 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cf7c532 - Browse repository at this point
Copy the full SHA cf7c532View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fe7c81 - Browse repository at this point
Copy the full SHA 5fe7c81View commit details -
Fix use of deprecated API and update test matrix (#1696)
* fix use of deprecated API and add python 3.10 test * test on pypy * fix syntax * clean up pypy * expand test matrix * cleanup * cleanup * fix install * fix windows test * fix windows test * fix windows test * fix windows test * fix windows test * fix excludes * fix tests on py310 * cleanup * cleanup
Configuration menu - View commit details
-
Copy full SHA for 708b217 - Browse repository at this point
Copy the full SHA 708b217View commit details -
Update nbconvert_library.ipynb (#1695)
The generated html file was not following the 'classic' template, but instead 'lab', when I ran the code according to documentaion. But when I passed the template_name as a keyword arguement to HTMLExporter it worked. So I made necessary changes to the code, in a way which worked for me. Please do a review of the code and accept the changes
Configuration menu - View commit details
-
Copy full SHA for 45df4b6 - Browse repository at this point
Copy the full SHA 45df4b6View commit details
Commits on Jan 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fc32d73 - Browse repository at this point
Copy the full SHA fc32d73View commit details -
Configuration menu - View commit details
-
Copy full SHA for b645841 - Browse repository at this point
Copy the full SHA b645841View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff cefe0bf...b645841