Allow disabling discovery issues reported by the Vintage engine #5049
+47
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether the Vintage engine should report discovery issues such as deprecation notices is now configurable via the new `junit.vintage.discovery.issue.reporting.enabled` configuration parameter. Resolves #5030.
sormuras
reviewed
Oct 10, 2025
junit-vintage-engine/src/main/java/org/junit/vintage/engine/discovery/VintageDiscoverer.java
Outdated
Show resolved
Hide resolved
sormuras
requested changes
Oct 10, 2025
Member
sormuras
left a comment
sormuras
left a comment
There was a problem hiding this comment.
One minor nit, otherwise looks good.
sbrannen
approved these changes
Oct 10, 2025
Co-authored-by: Christian Stein <[email protected]>
marcphilipp
deleted the
marc/5030-allow-disabling-vintage-discovery-issues
branch
matriv
added a commit
to crate/crate
that referenced
this pull request
Oct 21, 2025
Currently the upgrade leads to spam messages like the following: ``` The JUnit Vintage engine is deprecated and should only be used temporarily while migrating tests to JUnit Jupiter or another testing framework with native JUnit Platform support ``` The issue is addressed with: junit-team/junit-framework#5049 but will be released with 6.0.1. Follows: #18542
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Oct 21, 2025
Currently the upgrade leads to spam messages like the following: ``` The JUnit Vintage engine is deprecated and should only be used temporarily while migrating tests to JUnit Jupiter or another testing framework with native JUnit Platform support ``` The issue is addressed with: junit-team/junit-framework#5049 but will be released with 6.0.1. Follows: #18542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether the Vintage engine should report discovery issues such as
deprecation notices is now configurable via the new
junit.vintage.discovery.issue.reporting.enabledconfigurationparameter.
Resolves #5030.
Definition of Done
@APIannotations