Fix handling of CleanupMode.ON_SUCCESS
#4466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
commented
Apr 9, 2025
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java
Show resolved
Hide resolved
marcphilipp
commented
Apr 9, 2025
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java
Show resolved
Hide resolved
sormuras
approved these changes
Apr 9, 2025
Member
sormuras
left a comment
sormuras
left a comment
There was a problem hiding this comment.
Implementation and new test cases look good.
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java
Show resolved
Hide resolved
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java
Show resolved
Hide resolved
Prior to this commit, when a test failed all temp dirs created subsequently with `CleanupMode.ON_SUCCESS` were not deleted even if those tests passed. Fixes #4464.
marcphilipp
force-pushed
the
marc/4464-fix-on-success-cleanup-mode
branch
from
acf0ff2 to
b36e605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CleanupMode.ON_SUCCESSFixes #4464.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations