Report discovery issues for invalid test classes #4448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
marc/242-test-class-validation
branch
from
b3ef83b to
11d9969
Compare
36 tasks
There was a problem hiding this comment.
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/discovery/ClassSelectorResolver.java:86
- [nitpick] The term 'standalone test class' used here may be confused with non-nested classes. Consider clarifying the naming (in both the code and documentation) to differentiate standalone from member/nested test classes more clearly.
else if (isAcceptedStandaloneTestClass(testClass)) {
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Report discovery issues for invalid "standalone" and
@Nestedtest classes.Issue: #242
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotationsChange is documented in the User Guide and Release Noteswill be done in bulk later