Fix constructor invocation of Nested classes on Java versions < 21
#4419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sormuras
reviewed
Mar 23, 2025
| // Ensure that the outer instance is resolved as the first parameter if | ||
| // the executable is a constructor for an inner class. | ||
| if (outerInstance.isPresent()) { | ||
| Preconditions.condition(parameters[0].isImplicit(), "First parameter must be implicit"); |
Member
There was a problem hiding this comment.
Instead of deleting this check, wouldn't it be better to also apply the same isInnerClass(...) test?
Member
Author
There was a problem hiding this comment.
That's basically what outerInstance.isPresent() does. I only recently added this check when working on parameterized classes.
sormuras
reviewed
Mar 23, 2025
| private static Object resolveParameter(ParameterContext parameterContext, Executable executable, | ||
| ExtensionContextSupplier extensionContext, ExtensionRegistry extensionRegistry) { | ||
|
|
||
| Preconditions.condition(!parameterContext.getParameter().isImplicit(), |
Member
There was a problem hiding this comment.
Same here: replace test with isInnerClass(...) check applicable?
sormuras
approved these changes
Mar 23, 2025
marcphilipp
deleted the
marc/4417-fix-nested-constructor-parameter-resolution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4417.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations