Skip to content

Introduce ExtensionContext.getEnclosingTestClasses() #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcphilipp merged 3 commits into from
Mar 10, 2025
Merged

Introduce ExtensionContext.getEnclosingTestClasses() #4376

marcphilipp merged 3 commits into from
Mar 10, 2025

Conversation

@marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Mar 7, 2025

Overview

  • Link to correct method
  • Create initial 5.12.1 release notes from template
  • Introduce ExtensionContext.getEnclosingTestClasses()

Resolves #4375.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Mar 7, 2025
@marcphilipp marcphilipp requested a review from sbrannen March 7, 2025 14:25
sbrannen
sbrannen approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly reviewed the change set in the browser, and from I can tell... it looks good. 👍

I did notice, however, that TestClassAware will have to be backported to the 5.12.x branch and have its @API and @since tags updated (in case you haven't already done that).

@marcphilipp marcphilipp force-pushed the marc/4375-enclosing-test-classes branch from da7b3fc to 8c70099 Compare March 10, 2025 10:47
@marcphilipp marcphilipp merged commit ff6670a into main Mar 10, 2025
15 checks passed
@marcphilipp marcphilipp deleted the marc/4375-enclosing-test-classes branch March 10, 2025 10:58
@marcphilipp
Copy link
Member Author

marcphilipp commented Mar 10, 2025 •
edited by sbrannen
Loading

I did notice, however, that TestClassAware will have to be backported to the 5.12.x branch and have its @API and @since tags updated (in case you haven't already done that).

I've backported the changes to the 5.12.x branch and managed to get by without TestClassAware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@marcphilipp marcphilipp

Labels

component: Jupiter theme: extensions type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce ExtensionContext.getEnclosingTestClasses() for use with AnnotationSupport

3 participants

@marcphilipp @sbrannen