Use snapshot-tests to ease adapting assertions after changes to starter #4310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, changing the tests in the jupiter-starter sample project required to manually adapt the expected XML string in `XmlAssertions` which was tedious and time-consuming. Instead, the XML report is now checked against a snapshot that is committed to version control. When a diff is encountered, the affected test will fail. The actual and expected snapshots can then be diffed and, if ok, the actual snapshot can be used to overwrite the expected one. To avoid committing host names and usernames to source control, they are obfuscated prior to writing the snapshot files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, changing the tests in the jupiter-starter sample
project required to manually adapt the expected XML string in
XmlAssertionswhich was tedious and time-consuming. Instead, the XMLreport is now checked against a snapshot that is committed to version
control. When a diff is encountered, the affected test will fail. The
actual and expected snapshots can then be diffed and, if ok, the actual
snapshot can be used to overwrite the expected one.
To avoid committing host names and usernames to source control, they are
obfuscated prior to writing the snapshot files.