Warn when deleting symlinks targeting locations outside temp dir #4306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sormuras
approved these changes
Feb 10, 2025
YongGoose
approved these changes
Feb 10, 2025
Contributor
YongGoose
left a comment
YongGoose
left a comment
There was a problem hiding this comment.
It was an honor to review your code❕
It’s so clean that I only have one piece of feedback—and even that is just a minor code style improvement.
Great work!
Comment on lines
448
to
451
| assertThat(listener.stream(Level.WARNING)).map(LogRecord::getMessage) // | ||
| .contains(("Deleting symbolic link from location inside of temp dir (%s) " | ||
| + "to location outside of temp dir (%s) but not the target file/directory").formatted( | ||
| symbolicLink, directoryOutsideTempDir)); |
Contributor
There was a problem hiding this comment.
Suggested change
| assertThat(listener.stream(Level.WARNING)).map(LogRecord::getMessage) // | |
| .contains(("Deleting symbolic link from location inside of temp dir (%s) " | |
| + "to location outside of temp dir (%s) but not the target file/directory").formatted( | |
| symbolicLink, directoryOutsideTempDir)); | |
| assertThat(listener.stream(Level.WARNING)) // | |
| .map(LogRecord::getMessage) // | |
| .contains(("Deleting symbolic link from location inside of temp dir (%s) " | |
| + "to location outside of temp dir (%s) but not the target file/directory") // | |
| .formatted(symbolicLink, directoryOutsideTempDir)); |
This change looked a bit cleaner to me.
It's a very minor adjustment, so feel free to ignore it if you don’t think it’s necessary!
This is the change I’d like to make, but I’m not sure if it has been applied correctly... 😵💫
If you accept my change and it ends up failing at the check stage, I sincerely apologize..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #4303.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations