Skip to content

Put final link to gradle metadata documentation#2160

Closed
twasyl wants to merge 3 commits intojunit-team:releases/5.6.xfrom
twasyl:master
Closed

Put final link to gradle metadata documentation#2160
twasyl wants to merge 3 commits intojunit-team:releases/5.6.xfrom
twasyl:master

Conversation

@twasyl
Copy link
Copy Markdown

@twasyl twasyl commented Jan 22, 2020

Overview

I just updated the link to the gradle metadata page in the 5.60 release notes in order to point to the final version of the website instead of a RC version


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@sbrannen
Copy link
Copy Markdown
Member

Thanks for the PR.

Unfortunately, master has already been switched to work on 5.7.

Thus, this PR can no longer be applied on master.

If there is ever a 5.6 maintenance release (e.g., 5.6.1), we could consider updating the release notes then.

Another option would be to republish the 5.6 GA release notes with the updated link.

The latter is simple for the HTML version of the release notes but considerably more involved for the PDF version of the release notes.

Thus, I am inclined to leave it "as is".

@junit-team/junit-lambda, thoughts?

@mmerdes
Copy link
Copy Markdown
Contributor

mmerdes commented Jan 24, 2020

I agree with @sbrannen.
In case of a bug-fixing 5.6.1 it should be done there.

@twasyl
Copy link
Copy Markdown
Author

twasyl commented Jan 28, 2020

Hello,

Sure, I understand. Feel free to close this PR or keep it open in case of. It's up to you :)

Cheers

@marcphilipp marcphilipp changed the base branch from master to releases/5.6.x February 15, 2020 15:09
marcphilipp pushed a commit that referenced this pull request Feb 15, 2020
@marcphilipp
Copy link
Copy Markdown
Member

Thanks for the fix! I went ahead and created a release branch for 5.6.x so that we won't forget if we release a patch version for 5.6.x and manually changed it in the published release notes page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants