Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: junit-team/junit-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: r5.6.1
Choose a base ref
...
head repository: junit-team/junit-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: r5.6.2
Choose a head ref
  • 8 commits
  • 14 files changed
  • 2 contributors

Commits on Mar 22, 2020

  1. Configuration menu
    Copy the full SHA
    b0f54b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Fall back to display name if method name is blank

    Prior to this commit, `VintageTestDescriptor` used the `Description`'s
    method name when it wasn't null. However, there are edge cases where it
    can be empty which lead to blank display names which are not allowed by
    the Platform. Thus, it is now only used if not blank.
    
    Fixes #2248.
    marcphilipp committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    794ce24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef6e842 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    648121d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5cbfed5 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Avoid inner class cycle detection for non-matching predicate

    JUnit 5.6 introduced inner class cycle detection in
    ReflectionSupport.findNestedClasses() (see #2039). Unfortunately, the
    cycle detection introduced a regression for test classes that contain
    classes with inner class cycles when those inner classes do not match
    the predicate supplied to findNestedClasses() (e.g., "is annotated with
    @nested"). Consequently, an exception is thrown for any inner class
    cycled detected, even if the cycle would not adversely affect test
    discovery or execution.
    
    This commit fixes this regression by avoiding inner class cycle
    detection for candidate classes that do match the predicate. For
    example, within JUnit Jupiter inner class cycle detection is now only
    performed for inner classes annotated with @nested.
    
    Fixes #2249
    sbrannen committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    11ddd87 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Determine releaseBranch automatically based on version

    # Conflicts:
    #	documentation/documentation.gradle.kts
    marcphilipp committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    0be02cf View commit details
    Browse the repository at this point in the history
  2. Release 5.6.2

    marcphilipp committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4e7a087 View commit details
    Browse the repository at this point in the history
Loading