Repository navigation
fix(mac): reject custom kernels with the wrong bundled Python ABI - #3558
Merged
Merged
Conversation
Contributor
Author
Owner
|
Thanks for splitting this out. I verified the ABI checks against both the installed app’s Python and the local venvstacks export, and the mismatch tests pass. The guard runs before kernel cleanup and preserves the existing MLX and nanobind checks. LGTM, I’ll merge this. |
kaushikvira
pushed a commit
to kaushikvira/omlx
that referenced
this pull request
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app build can compile custom kernels with a different CPython ABI from the donor app's embedded interpreter, even when the build-time import succeeds. Compare the two interpreters before compilation, then validate the native
_extsuffixes actually staged into the bundle. Existing MLX and nanobind checks remain in place.This is the focused app ABI follow-up requested in #2640. Validation at
ccea85b75758e5f1bd1d459c4726f847e3c0f04b: 8 regression tests passed, covering matching and mismatched ABIs, failed interpreter queries, staged suffix mismatches and missing extensions. Full app building and signing were not run.Please review the donor-runtime selection and the fail-closed packaging behavior.