Skip to content

Developed RandEvent and add statement-based logging test - #414

Merged
julien-duponchelle merged 24 commits into
julien-duponchelle:mainfrom
python-mysql-replication-kr:feature/rand-event
Aug 20, 2023
Merged

julien-duponchelle merged 24 commits into
julien-duponchelle:mainfrom
python-mysql-replication-kr:feature/rand-event

Conversation

@heehehe

@heehehe heehehe commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

1. Developed RandEvent

2. Add statement-based logging test : TestStatementConnectionSetting

  • Since RandEvent only works with "statement-based logging",
    we added TestStatementConnectionSetting class in pymysqlreplication/tests/test_basic.py
    and set binlog_format='STATEMENT' only in this class.
  • Any other events with statement-based logging could be tested in this class.

@julien-duponchelle

Copy link
Copy Markdown
Owner

Awesome. Can you solve the conflicts? I think I introduce conflict with my last merge

@mikaniz

mikaniz commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

Awesome. Can you solve the conflicts? I think I introduce conflict with my last merge

I solved the conflicts. Thanks!

@julien-duponchelle
julien-duponchelle merged commit 986bf5c into julien-duponchelle:main Aug 20, 2023
@julien-duponchelle

Copy link
Copy Markdown
Owner

Great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants