Make the README less misleading by putting some reasonable defaults in (instead of empty strings '')#302
Conversation
…n (instead of empty strings `''`)
|
Probably do the same for the version too? |
Yeah. But what do we want to put in there? |
|
The default? |
DilumAluthge
requested review from
IanButterworth
and removed request for
IanButterworth
| # | ||
| # Default: false |
There was a problem hiding this comment.
| # | |
| # Default: false |
There was a problem hiding this comment.
Hmmm. I'm a bit conflicted on this. I don't know if the following line (show-versioninfo: 'false') makes it sufficiently clear that false is the default value. I think I'd probably lean towards keeping the line that clarifies that false is the default value.
| # | ||
| # Default: '1' |
There was a problem hiding this comment.
| # | |
| # Default: '1' |
Co-authored-by: Jameson Nash <[email protected]>
|
@IanButterworth Any idea why those two CI checks are showing up as "cancelled". |
|
Hmmm. Those two jobs keep showing up as canceled, and thus I cannot merge this PR. |
|
I guess it's actions/runner-images#10721 because they're |
|
I see. I will remove those two |
3 participants
No description provided.