Skip to content

Improve example version instructions. Add info about "lts" if user specifies 1.6 explicitly#265

Merged
IanButterworth merged 15 commits intomasterfrom
ib/lts_info
Jul 21, 2024
Merged

Improve example version instructions. Add info about "lts" if user specifies 1.6 explicitly#265
IanButterworth merged 15 commits intomasterfrom
ib/lts_info

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth commented Jul 19, 2024

  • I haven't found a way to catch Error if version isn't a string #204 so explain the issue in the instructions
  • In preparation for 1.10 becoming LTS promote users to use "lts" rather than specify "1.6" explicitly.

i.e.
Screenshot 2024-07-19 at 10 43 11 AM

@IanButterworth IanButterworth requested a review from a team as a code owner July 19, 2024 14:05
@DilumAluthge
Copy link
Copy Markdown
Member

Did we ever make a Discourse post announcing the version: lts feature? I could have sworn you made one, but I'm not able to find it now.

@IanButterworth
Copy link
Copy Markdown
Member Author

@DilumAluthge
Copy link
Copy Markdown
Member

@IanButterworth Looks like you might need to do npm ci && npm run build again?

DilumAluthge
DilumAluthge previously approved these changes Jul 19, 2024
@IanButterworth IanButterworth enabled auto-merge (squash) July 20, 2024 11:48
@IanButterworth IanButterworth merged commit 0c41305 into master Jul 21, 2024
@IanButterworth IanButterworth deleted the ib/lts_info branch July 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants