Use the eager Pkg server registry, by default#30
Use the eager Pkg server registry, by default#30DilumAluthge wants to merge 14 commits intomasterfrom
eager Pkg server registry, by default#30Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
What is needed to push this over the finish line? For example for Literate.jl, CI takes 7m14s for Windows but 1m45s for Ubuntu. (https://github.com/fredrikekre/Literate.jl/actions/runs/3950203865/jobs/6762429082). It seems extremely wasteful that the Julia ecosystem use so much CI for this. I am sure eager registry is fine, but an alternative would be to download the current snapshot of General#master from GitHub directly. |
| pref_key = "JULIA_PKG_SERVER_REGISTRY_PREFERENCE" | ||
| pref_value = strip(get(ENV, pref_key, "eager")) | ||
| ENV[pref_key] = pref_value | ||
| input = strip(ENV["PROPAGATE_INPUT"]) |
There was a problem hiding this comment.
What is this PROPAGATE_INPUT stuff? I'm confused why this fix is not a lot simpler; just set the env variable and done? It seems it is adding these extra options that are pretty unlikely to be used in practice. If someone wants some special behavior they can just add that to their own CI files.
There was a problem hiding this comment.
I was about to say the same. If you need this then it should go in the root environment key of the CI job description. It seems strange that it is "hidden" in the buildpkg action (which most packages should not need to use anyway).
|
superseded by #31 but thanks for opening this PR! |
5 participants
Fixes #14