Skip to content

use Pkg server and eager registry by default#29

Closed
visr wants to merge 1 commit intojulia-actions:masterfrom
visr:pkgserver
Closed

use Pkg server and eager registry by default#29
visr wants to merge 1 commit intojulia-actions:masterfrom
visr:pkgserver

Conversation

@visr
Copy link
Copy Markdown

@visr visr commented Jan 27, 2023

This speeds up julia-buildpkg considerably.
Fixes #14

@visr visr requested a review from a team as a code owner January 27, 2023 14:33
This speeds up julia-buildpkg considerably.
Fixes julia-actions#14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (deadd47) compared to base (252d468).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@visr
Copy link
Copy Markdown
Author

visr commented Jan 27, 2023

If this is merged, in the repo settings the required status check in the branch protection rules probably need to be updated. They are also outdated right now which is why the status for them doesn't get reported.

@SaschaMann
Copy link
Copy Markdown
Member

If this is merged, in the repo settings the required status check in the branch protection rules probably need to be updated. They are also outdated right now which is why the status for them doesn't get reported.

I've removed required checks in the meantime until this has been reviewed & merged.

@visr
Copy link
Copy Markdown
Author

visr commented Feb 4, 2023

@DilumAluthge is this what you had in mind with this comment: #14 (comment)?

@DilumAluthge
Copy link
Copy Markdown
Member

I think we’ll need a couple additional tweaks. I’ll try to look into this in more detail next week.

@DilumAluthge
Copy link
Copy Markdown
Member

I'm still looking into this. I need to get a bit more information on how eager/conservative registries work.

@SaschaMann
Copy link
Copy Markdown
Member

SaschaMann commented Mar 13, 2023

superseded by #31 but thanks for opening this PR!

@SaschaMann SaschaMann closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider using Pkg server by default for the registry

4 participants