Skip to content

Extend cache action#4

Merged
SaschaMann merged 8 commits intomainfrom
rh/extend
Dec 27, 2021
Merged

Extend cache action#4
SaschaMann merged 8 commits intomainfrom
rh/extend

Conversation

@rikhuijzer
Copy link
Copy Markdown
Member

Closes #2.

@rikhuijzer rikhuijzer marked this pull request as ready for review December 27, 2021 19:01
@rikhuijzer
Copy link
Copy Markdown
Member Author

rikhuijzer commented Dec 27, 2021

The current failures are because the cache-name which is passed from test-save to test-restore is not always passed to the same operating system, as figured out by manually checking the keys and noticing that the Ubuntu save key is used in the Windows restore steps. Then, the restore key doesn't match anymore so it is an unexpected cache miss.

@rikhuijzer
Copy link
Copy Markdown
Member Author

Great. Everything works again and is now tested on all three operating systems.

I've considered testing the PATHS logic more, but chose not too for now. It is already covered pretty well since currently two things are tested:

  • artifacts is inside PATHS (otherwise, the artifacts will not be cached and the last job in CI.yml will fail)
  • the PATHS newlines are properly propagated into cache.key (otherwise, nothing will be cached at all and the last job in CI.yml will fail)

Copy link
Copy Markdown
Member

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you update the README as well, please? Should we rename this to julia-actions/cache then?

Co-authored-by: Sascha Mann <[email protected]>
@rikhuijzer
Copy link
Copy Markdown
Member Author

Should we rename this to julia-actions/cache then?

Maybe, cache-julia to be in line with setup-julia, julia-buildpkg, julia-runtest etc? I find the names a bit double so just cache makes more sense indeed. Maybe to avoid clashing fork names?

Good idea to rename. I'll leave the decision up to you to what exactly. I'm okay with cache, cache-julia and similar names.

Co-authored-by: Sascha Mann <[email protected]>
@SaschaMann
Copy link
Copy Markdown
Member

cache-julia sounds like it caches Julia which it doesn't (and probably shouldn't), I'll go with just cache then

@rikhuijzer
Copy link
Copy Markdown
Member Author

cache-julia sounds like it caches Julia which it doesn't (and probably shouldn't), I'll go with just cache then

Fair enough 👍

I'm seeing some possible discussion points in the README too. Can we merge this first to avoid having a too long PR? Then, I'll open a new PR for the README

@SaschaMann SaschaMann merged commit 905462d into main Dec 27, 2021
@SaschaMann SaschaMann deleted the rh/extend branch December 27, 2021 20:52
@SaschaMann
Copy link
Copy Markdown
Member

I'm seeing some possible discussion points in the README too. Can we merge this first to avoid having a too long PR? Then, I'll open a new PR for the README

Yea that's fine. I'll tag a new release once the README has been updated then :)

@rikhuijzer
Copy link
Copy Markdown
Member Author

Thank you for that and also for the reviews 😄 I've learned some things from them

I'll do the README tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend the action to packages and registry

2 participants