Fixes to #190: Javascript version of existing action which also saves if job fails#198
Merged
IanButterworth merged 23 commits intomainfrom Mar 7, 2026
Merged
Fixes to #190: Javascript version of existing action which also saves if job fails#198IanButterworth merged 23 commits intomainfrom
IanButterworth merged 23 commits intomainfrom
Conversation
Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
Co-authored-by: Penelope Yong <[email protected]>
- Fix du glob expansion: use bash -c so * is shell-expanded - Reorder post.js: save cache before deleting old caches - Fix cache-hit output: return '' (not 'false') on partial match - Replace DataFrames with lightweight Example package in CI tests - Unify actions/checkout to v6.0.1 across all CI jobs - Remove unused direct deps (glob, io, protobuf-ts/runtime) - Update action runtime from node20 to node24 - Regenerate package-lock.json with correct version (3.0.0) Co-authored-by: Claude <[email protected]>
IanButterworth
force-pushed
the
ib/190_tweaks
branch
from
7caf979 to
09485b2
Compare
IanButterworth
changed the title
Contributor
|
Thanks for continuing with this, the list of changes looks reasonable to me |
Member
Author
|
Ok, I'll go ahead with this one. Thanks! And sorry for the delay |
This was referenced Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #190
@jkrumbiegel Opus 4.6 has these suggestions which I thought were reasonable, and I suggested the Node 24 update given we're making a breaking change.