Skip to content

fix windows depot path expansion#146

Merged
IanButterworth merged 1 commit intomainfrom
ib/fix_windows
Sep 23, 2024
Merged

fix windows depot path expansion#146
IanButterworth merged 1 commit intomainfrom
ib/fix_windows

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth commented Sep 23, 2024 •
edited
Loading

Fixes #145
I guess the bug came from #141 but I'm not sure the situation was better before that.

I'll test externally to check.

@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Sep 23, 2024

Fixed as demonstrated here https://github.com/JuliaIO/VideoIO.jl/actions/runs/10996020832/job/30528234720?pr=423#step:13:11

depot=C:\Users\runneradmin/.julia
cache-paths<<EOF
C:\Users\runneradmin/.julia/artifacts
C:\Users\runneradmin/.julia/packages
C:\Users\runneradmin/.julia/registries
C:\Users\runneradmin/.julia/compiled
C:\Users\runneradmin/.julia/scratchspaces
C:\Users\runneradmin/.julia/logs
EOF

@IanButterworth IanButterworth marked this pull request as ready for review September 23, 2024 14:14
@IanButterworth IanButterworth requested a review from omus September 23, 2024 14:14
@IanButterworth IanButterworth enabled auto-merge (squash) September 23, 2024 14:58
@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Sep 23, 2024

I'd just merge this and release if I could. The change is pretty isolated so perhaps someone else could review? @DilumAluthge perhaps?

@IanButterworth IanButterworth merged commit 8242439 into main Sep 23, 2024
@IanButterworth IanButterworth deleted the ib/fix_windows branch September 23, 2024 17:30
@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Sep 23, 2024

Thanks!

@jkrumbiegel
Copy link
Copy Markdown
Contributor

jkrumbiegel commented Sep 23, 2024

Thanks for the fix :)

@jpfairbanks jpfairbanks mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

@omus omus Awaiting requested review from omus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Caching doesn't work on Windows with default settings

3 participants

@IanButterworth @jkrumbiegel @DilumAluthge