Merged
Conversation
omus
previously approved these changes
Aug 9, 2024
Collaborator
omus
left a comment
omus
left a comment
There was a problem hiding this comment.
In an ideal world we'd avoid performing the registry update on up to date registries. We can always add such an optimization after the fact.
Co-authored-by: Curtis Vogt <[email protected]>
Member
Author
|
(I'd merge but approval is required here) |
Member
Author
|
Can I get an approval on this. I didn't intentionally dismiss @omus 's approval. For some reason github did when I merged the suggestion. or @DilumAluthge if you wouldn't mind |
DilumAluthge
approved these changes
Aug 12, 2024
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110