Repository navigation
Commit 49be3fc
committed
build: unify compiler flag sets across cuda-bindings and cuda-core
Close the audit from NVIDIA#1882. The two packages' Linux and MSVC flag sets had
drifted for legacy reasons; both now go through the same structure.
Changes in cuda-bindings:
- Drop -fpermissive and -fno-var-tracking-assignments (gcc-only; not
needed by current Cython-generated C++; confirmed by a rebuild).
- Change -O3 to -O2 (consistent with cuda-core; -O3 was not the source
of the measured launch_{256,512}_args latency difference vs c++17).
- Add /std:c++14 and /O2 on MSVC (was missing entirely).
- Split '-std=c++14 -Wno-deprecated-declarations' onto separate lines
with an explanatory comment on each.
Changes in cuda-core:
- Add /O2 on MSVC (modern setuptools no longer forces /Ox).
- Add comments at both the MSVC and Linux flag sites explaining why
c++17 is required (structured bindings / if constexpr in _cpp/).
Tests:
- Update the bindings TestResolveToolchain: replace test_gnu_keeps_gcc_only_flags
with test_linux_opt_flag_set (asserts -O2, not -O3; no gnu-only flags);
add test_msvc_opt_flag_set; update test_gnu_sets_env_and_flags assertions.
- Add test_linux_opt_flag_set and test_msvc_opt_flag_set to the core
TestResolveToolchain; update the comment in test_gnu_sets_env_and_flags.1 parent 8c03e61 commit 49be3fc
4 files changed
Lines changed: 67 additions & 18 deletions
File tree
- cuda_bindings
- tests
- cuda_core
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
440 | 443 | | |
441 | 444 | | |
442 | 445 | | |
443 | 446 | | |
444 | | - | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
445 | 454 | | |
446 | | - | |
447 | | - | |
448 | | - | |
| 455 | + | |
449 | 456 | | |
450 | 457 | | |
451 | 458 | | |
452 | 459 | | |
453 | 460 | | |
454 | | - | |
| 461 | + | |
455 | 462 | | |
456 | 463 | | |
457 | 464 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | | - | |
152 | | - | |
153 | | - | |
| 151 | + | |
| 152 | + | |
154 | 153 | | |
155 | 154 | | |
156 | 155 | | |
| |||
167 | 166 | | |
168 | 167 | | |
169 | 168 | | |
170 | | - | |
171 | | - | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
172 | 172 | | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
178 | 194 | | |
179 | 195 | | |
180 | 196 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
487 | | - | |
| 487 | + | |
| 488 | + | |
488 | 489 | | |
489 | 490 | | |
490 | 491 | | |
491 | 492 | | |
| 493 | + | |
492 | 494 | | |
493 | 495 | | |
494 | 496 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
976 | 976 | | |
977 | 977 | | |
978 | 978 | | |
979 | | - | |
980 | | - | |
| 979 | + | |
| 980 | + | |
981 | 981 | | |
982 | 982 | | |
983 | 983 | | |
| |||
1018 | 1018 | | |
1019 | 1019 | | |
1020 | 1020 | | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
1021 | 1045 | | |
1022 | 1046 | | |
1023 | 1047 | | |
| |||
0 commit comments