Allow specifying storage space mounts in container config #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Apr 8, 2021
ambarve
force-pushed
the
storage_space_data_disk
branch
from
c1fd0f5 to
dd6d53b
Compare
Signed-off-by: Amit Barve <[email protected]>
ambarve
force-pushed
the
storage_space_data_disk
branch
from
dd6d53b to
a139901
Compare
msscotb
reviewed
Apr 12, 2021
| } | ||
| src = formattedSource | ||
| mountType = "virtual-disk" | ||
| } else if strings.HasPrefix(src, `evd://`) { |
There was a problem hiding this comment.
Minor point, is it common practice to use backticks even if there are no escaped characters to ignore? Seems like this routine double quotes are used where there are no back slashes.
Author
There was a problem hiding this comment.
I think I had used them earlier because I had some special character but then I didn't changed it back. Do you want me to change this to normal quotes?
katiewasnothere
approved these changes
Jun 25, 2021
|
@katiewasnothere @kevpar Can one of you merge this? |
ambarve
added a commit
to ambarve/cri
that referenced
this pull request
Mar 31, 2022
Related work items: jterry75#97, jterry75#100, jterry75#101, jterry75#103, jterry75#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Barve [email protected]