Add support for binary logger #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
2 tasks
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
2 times, most recently
from
a69b5dc to
aae67e6
Compare
dcantah
reviewed
Nov 19, 2020
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
from
aae67e6 to
d7d8c65
Compare
dcantah
reviewed
Nov 19, 2020
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
2 times, most recently
from
bf9ef13 to
a62dcdd
Compare
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
2 times, most recently
from
e3470a1 to
74c20f1
Compare
dcantah
reviewed
Nov 30, 2020
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
from
74c20f1 to
53b90c8
Compare
dcantah
reviewed
Nov 30, 2020
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
2 times, most recently
from
6a21e2a to
c92d35d
Compare
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
from
c92d35d to
fe793ca
Compare
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
3 times, most recently
from
be6e30b to
d246463
Compare
katiewasnothere
approved these changes
Dec 22, 2020
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
I requested a comment but not really necessary, LGTM
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
from
d246463 to
d1d3468
Compare
Signed-off-by: Maksim An <[email protected]>
anmaxvl
force-pushed
the
user/maksiman/add-binary-logging-support
branch
from
d1d3468 to
47d179d
Compare
Author
|
@katiewasnothere or @kevpar can we merge this? |
ambarve
added a commit
to ambarve/cri
that referenced
this pull request
Mar 31, 2022
Related work items: jterry75#82, jterry75#86, jterry75#88, jterry75#91, jterry75#92, jterry75#93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for providing a custom binary logger via
log_pathcontainer config.As also described in microsoft/hcsshim#896,
if
log_pathcontains abinary://scheme,ctr-x-stdout/stderrwon'tbe created anymore, and it becomes hcsshim's responsibility to route
container IO to the binary.
Signed-off-by: Maksim An [email protected]