Test false positive component detection for destructured createElement#1098
Merged
ljharb merged 1 commit intojsx-eslint:masterfrom Dec 27, 2018
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1089 (comment)
Before that pull request an arrow function such as:
() => foo(bar("x"))would be detected as a component ifcreateElementwas destructured (import {createElement} from 'react').This adds a test for display-name that it's ok that a function like that does not need a display name, as it's not a component.