Improve title in void-dom-elements-no-children.md#1078
Closed
omerzach wants to merge 2 commits intojsx-eslint:masterfrom
Closed
Improve title in void-dom-elements-no-children.md#1078omerzach wants to merge 2 commits intojsx-eslint:masterfrom
omerzach wants to merge 2 commits intojsx-eslint:masterfrom
Conversation
Add the name of the rule in parentheses at the end of Markdown title like in other documentation files.
ljharb
reviewed
Feb 18, 2017
| @@ -1,4 +1,4 @@ | |||
| # Prevent void DOM elements (e.g. `<img />`, `<br />`) from receiving children | |||
| # Prevent void DOM elements (e.g. `<img />`, `<br />`) from receiving children (void-dom-elements-no-children) | |||
Member
There was a problem hiding this comment.
Per #1071, this should probably have a "react/" prefix.
Contributor
Author
|
Ah I was hoping I could squash the commits from within the GitHub UI but I guess not |
Contributor
Author
|
I'm bad at GitHub so I'm going to close this and open a new one. Sorry. |
Member
|
Yeah you need to use the command line - in the future, please have a collab do it for you instead of opening up a duplicate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the name of the rule in parentheses at the end of Markdown title like in other documentation files.