Skip to content

docs(prefer-es6-class): add missing prefix#1071

Merged
ljharb merged 2 commits intojsx-eslint:masterfrom
adnasa:typo-prefer-es6-class
May 16, 2017
Merged

docs(prefer-es6-class): add missing prefix#1071
ljharb merged 2 commits intojsx-eslint:masterfrom
adnasa:typo-prefer-es6-class

Conversation

@adnasa
Copy link
Copy Markdown
Contributor

@adnasa adnasa commented Feb 14, 2017

figured...

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Feb 14, 2017

All of the rules docs omit the react/ prefix, by convention.

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Feb 14, 2017

@ljharb all of them?

at least from my side, this caused some confusion when setting up the config initially.

@adnasa adnasa changed the title docs(prefer-es6-class): correct typo in doc docs(prefer-es6-class): add missing prefix Feb 14, 2017
lencioni
lencioni approved these changes Feb 14, 2017
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as an improvement. It would be nice to make them all consistent though.

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Feb 14, 2017 •
edited
Loading

@lencioni yeah I agree on consistency 😉 let's do that (on a separate PR)!

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Feb 14, 2017

As long as they're all the same, I'm happy :-) it'd be nice to update this PR to do all of them, but a separate one is fine too.

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Feb 15, 2017

you're right. we can do it in this PR

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Feb 15, 2017

@ljharb @lencioni done

lencioni
lencioni approved these changes Feb 15, 2017
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread docs/rules/self-closing-comp.md
@@ -1,4 +1,4 @@
# Prevent extra closing tags for components without children (self-closing-comp)
# Prevent extra closing tags for components without children (react/self-closing-comp)
Copy link
Copy Markdown
Collaborator

@lencioni lencioni Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have missed some other lines like this one (e.g. see require-optimization). It might be worth making another pass.

Copy link
Copy Markdown
Contributor Author

@adnasa adnasa Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, I wasn't supposed to add the prefix on the title. shall we proceed with this? 😛

@lencioni lencioni mentioned this pull request Feb 15, 2017
Merged
@ljharb ljharb mentioned this pull request Feb 18, 2017
Closed
@ljharb
Copy link
Copy Markdown
Member

ljharb commented Feb 18, 2017 •
edited
Loading

@adnasa it looks like this needs a rebase, and it seems like #1078 has found a file that your PR doesn't update.

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Feb 18, 2017

@ljharb an update is coming up later this weekend 😉

@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented Feb 19, 2017 •
edited
Loading

@ljharb corrected the merge conflict 6334d63

@ljharb
Copy link
Copy Markdown
Member

ljharb commented Feb 19, 2017

@adnasa would you mind rebasing so as to remove the merge commit?

@yannickcr yannickcr mentioned this pull request Mar 22, 2017
Merged
@adnasa adnasa force-pushed the typo-prefer-es6-class branch from 9622ac6 to 5a02508 Compare May 16, 2017 05:07
@adnasa
Copy link
Copy Markdown
Contributor Author

adnasa commented May 16, 2017

@ljharb Hey,
Sorry for being late on this! 😋
I finally did it, haha

@ljharb ljharb merged commit ecc327a into jsx-eslint:master May 16, 2017
@adnasa adnasa deleted the typo-prefer-es6-class branch May 16, 2017 07:56
@renovate renovate Bot mentioned this pull request Feb 2, 2018
Open
1 task
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
Open
@renovate renovate Bot mentioned this pull request Oct 27, 2018
Open
1 task
@renovate renovate Bot mentioned this pull request Nov 7, 2018
Merged
@renovate renovate Bot mentioned this pull request Nov 23, 2018
Open
1 task
@renovate renovate Bot mentioned this pull request Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this pull request Dec 19, 2018
Closed
1 task
github-actions Bot pushed a commit to capitnflam/eslint-plugin that referenced this pull request Mar 16, 2024
@semantic-release-bot
release(version): Release 1.1.0 [skip ci]
bf7c725 
# [1.1.0](v1.0.1...v1.1.0) (2024-03-16)

### chore

* **deps-dev:** bump [@types](https://github.com/types)/node from 20.11.27 to 20.11.28 ([#13](#13)) ([738e28c](738e28c))
* **deps:** bump eslint-plugin-react from 7.34.0 to 7.34.1 ([#12](#12)) ([ad9f1b3](ad9f1b3)), closes [#3700](https://github.com/capitnflam/eslint-plugin/issues/3700) [#3701](https://github.com/capitnflam/eslint-plugin/issues/3701) [#3704](https://github.com/capitnflam/eslint-plugin/issues/3704) [#3705](https://github.com/capitnflam/eslint-plugin/issues/3705) [#3707](https://github.com/capitnflam/eslint-plugin/issues/3707) [#3713](https://github.com/capitnflam/eslint-plugin/issues/3713) [#3715](https://github.com/capitnflam/eslint-plugin/issues/3715) [#1000](https://github.com/capitnflam/eslint-plugin/issues/1000) [jsx-eslint/eslint-plugin-react#1000](jsx-eslint/eslint-plugin-react#1000) [#1002](https://github.com/capitnflam/eslint-plugin/issues/1002) [jsx-eslint/eslint-plugin-react#1002](jsx-eslint/eslint-plugin-react#1002) [#1005](https://github.com/capitnflam/eslint-plugin/issues/1005) [jsx-eslint/eslint-plugin-react#1005](jsx-eslint/eslint-plugin-react#1005) [#100](https://github.com/capitnflam/eslint-plugin/issues/100) [jsx-eslint/eslint-plugin-react#100](jsx-eslint/eslint-plugin-react#100) [#1010](https://github.com/capitnflam/eslint-plugin/issues/1010) [jsx-eslint/eslint-plugin-react#1010](jsx-eslint/eslint-plugin-react#1010) [#1013](https://github.com/capitnflam/eslint-plugin/issues/1013) [jsx-eslint/eslint-plugin-react#1013](jsx-eslint/eslint-plugin-react#1013) [#1022](https://github.com/capitnflam/eslint-plugin/issues/1022) [jsx-eslint/eslint-plugin-react#1022](jsx-eslint/eslint-plugin-react#1022) [#1029](https://github.com/capitnflam/eslint-plugin/issues/1029) [jsx-eslint/eslint-plugin-react#1029](jsx-eslint/eslint-plugin-react#1029) [#102](https://github.com/capitnflam/eslint-plugin/issues/102) [jsx-eslint/eslint-plugin-react#102](jsx-eslint/eslint-plugin-react#102) [#1034](https://github.com/capitnflam/eslint-plugin/issues/1034) [jsx-eslint/eslint-plugin-react#1034](jsx-eslint/eslint-plugin-react#1034) [#1038](https://github.com/capitnflam/eslint-plugin/issues/1038) [jsx-eslint/eslint-plugin-react#1038](jsx-eslint/eslint-plugin-react#1038) [#1041](https://github.com/capitnflam/eslint-plugin/issues/1041) [jsx-eslint/eslint-plugin-react#1041](jsx-eslint/eslint-plugin-react#1041) [#1043](https://github.com/capitnflam/eslint-plugin/issues/1043) [jsx-eslint/eslint-plugin-react#1043](jsx-eslint/eslint-plugin-react#1043) [#1046](https://github.com/capitnflam/eslint-plugin/issues/1046) [jsx-eslint/eslint-plugin-react#1046](jsx-eslint/eslint-plugin-react#1046) [#1047](https://github.com/capitnflam/eslint-plugin/issues/1047) [jsx-eslint/eslint-plugin-react#1047](jsx-eslint/eslint-plugin-react#1047) [#1050](https://github.com/capitnflam/eslint-plugin/issues/1050) [jsx-eslint/eslint-plugin-react#1050](jsx-eslint/eslint-plugin-react#1050) [#1053](https://github.com/capitnflam/eslint-plugin/issues/1053) [jsx-eslint/eslint-plugin-react#1053](jsx-eslint/eslint-plugin-react#1053) [#1057](https://github.com/capitnflam/eslint-plugin/issues/1057) [jsx-eslint/eslint-plugin-react#1057](jsx-eslint/eslint-plugin-react#1057) [#105](https://github.com/capitnflam/eslint-plugin/issues/105) [jsx-eslint/eslint-plugin-react#105](jsx-eslint/eslint-plugin-react#105) [#1061](https://github.com/capitnflam/eslint-plugin/issues/1061) [jsx-eslint/eslint-plugin-react#1061](jsx-eslint/eslint-plugin-react#1061) [#1062](https://github.com/capitnflam/eslint-plugin/issues/1062) [jsx-eslint/eslint-plugin-react#1062](jsx-eslint/eslint-plugin-react#1062) [#1070](https://github.com/capitnflam/eslint-plugin/issues/1070) [jsx-eslint/eslint-plugin-react#1070](jsx-eslint/eslint-plugin-react#1070) [#1071](https://github.com/capitnflam/eslint-plugin/issues/1071) [jsx-eslint/eslint-plugin-react#1071](jsx-eslint/eslint-plugin-react#1071) [#1073](https://github.com/capitnflam/eslint-plugin/issues/1073) [jsx-eslint/eslint-plugin-react#1073](jsx-eslint/eslint-plugin-react#1073) [#1076](https://github.com/capitnflam/eslint-plugin/issues/1076) [jsx-eslint/eslint-plugin-react#1076](jsx-eslint/eslint-plugin-react#1076) [#1079](https://github.com/capitnflam/eslint-plugin/issues/1079) [jsx-eslint/eslint-plugin-react#1079](jsx-eslint/eslint-plugin-react#1079) [#1088](https://github.com/capitnflam/eslint-plugin/issues/1088) [jsx-eslint/eslint-plugin-react#1088](jsx-eslint/eslint-plugin-react#1088) [#1098](https://github.com/capitnflam/eslint-plugin/issues/1098) [jsx-eslint/eslint-plugin-react#1098](jsx-eslint/eslint-plugin-react#1098) [#1101](https://github.com/capitnflam/eslint-plugin/issues/1101) [jsx-eslint/eslint-plugin-react#1101](jsx-eslint/eslint-plugin-react#1101) [#1103](https://github.com/capitnflam/eslint-plugin/issues/1103) [jsx-eslint/eslint-plugin-react#1103](jsx-eslint/eslint-plugin-react#1103) [#110](https://github.com/capitnflam/eslint-plugin/issues/110) [jsx-eslint/eslint-plugin-react#110](jsx-eslint/eslint-plugin-react#110) [#1116](https://github.com/capitnflam/eslint-plugin/issues/1116) [jsx-eslint/eslint-plugin-react#1116](jsx-eslint/eslint-plugin-react#1116) [#1117](https://github.com/capitnflam/eslint-plugin/issues/1117) [jsx-eslint/eslint-plugin-react#1117](jsx-eslint/eslint-plugin-react#1117) [#1119](https://github.com/capitnflam/eslint-plugin/issues/1119) [jsx-eslint/eslint-plugin-react#1119](jsx-eslint/eslint-plugin-react#1119) [#1121](https://github.com/capitnflam/eslint-plugin/issues/1121) [jsx-eslint/eslint-plugin-react#1121](jsx-eslint/eslint-plugin-react#1121) [#1122](https://github.com/capitnflam/eslint-plugin/issues/1122) [jsx-eslint/eslint-plugin-react#1122](jsx-eslint/eslint-plugin-react#1122) [#1123](https://github.com/capitnflam/eslint-plugin/issues/1123) [jsx-eslint/eslint-plugin-react#1123](jsx-eslint/eslint-plugin-react#1123) [#3700](https://github.com/capitnflam/eslint-plugin/issues/3700) [#3701](https://github.com/capitnflam/eslint-plugin/issues/3701) [#3704](https://github.com/capitnflam/eslint-plugin/issues/3704) [#3705](https://github.com/capitnflam/eslint-plugin/issues/3705) [#3707](https://github.com/capitnflam/eslint-plugin/issues/3707) [#3713](https://github.com/capitnflam/eslint-plugin/issues/3713) [#3715](https://github.com/capitnflam/eslint-plugin/issues/3715) [#3715](https://github.com/capitnflam/eslint-plugin/issues/3715) [jsx-eslint/eslint-plugin-react#3715](jsx-eslint/eslint-plugin-react#3715) [#3713](https://github.com/capitnflam/eslint-plugin/issues/3713) [jsx-eslint/eslint-plugin-react#3713](jsx-eslint/eslint-plugin-react#3713) [#3707](https://github.com/capitnflam/eslint-plugin/issues/3707) [jsx-eslint/eslint-plugin-react#3707](jsx-eslint/eslint-plugin-react#3707) [#3705](https://github.com/capitnflam/eslint-plugin/issues/3705) [jsx-eslint/eslint-plugin-react#3705](jsx-eslint/eslint-plugin-react#3705) [#3704](https://github.com/capitnflam/eslint-plugin/issues/3704) [jsx-eslint/eslint-plugin-react#3704](jsx-eslint/eslint-plugin-react#3704) [#3701](https://github.com/capitnflam/eslint-plugin/issues/3701) [jsx-eslint/eslint-plugin-react#3701](jsx-eslint/eslint-plugin-react#3701) [#3700](https://github.com/capitnflam/eslint-plugin/issues/3700) [jsx-eslint/eslint-plugin-react#3700](jsx-eslint/eslint-plugin-react#3700)

### ci

* add auto assign action ([#14](#14)) ([07d1f9a](07d1f9a))
* add check workflow ([#11](#11)) ([8afc82a](8afc82a))

### feat

* add [@eslint-community](https://github.com/eslint-community)/eslint-plugin-eslint-comments ([#17](#17)) ([fe2bf30](fe2bf30))
* add eslint-plugin-n ([#18](#18)) ([203d603](203d603))
* add eslint-plugin-security ([#16](#16)) ([e7f8c2e](e7f8c2e))
* add eslint-plugin-sonarjs ([#15](#15)) ([5bca4e1](5bca4e1))
* **react:** add some security linting ([#10](#10)) ([4424b67](4424b67))
@gabrc52 gabrc52 mentioned this pull request Jul 15, 2024
Merged
@mindthecap mindthecap mentioned this pull request Jul 15, 2024
Merged
renovate Bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
@renovate