[Refactor] jsx-props-no-multi-spaces: extract type parameters to var

HenryBrown0 · ljharb · commit ca30f77196d4 · 2023-09-24T13:42:03.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 * [Refactor] `propTypes`: extract type params to var ([#3634][] @HenryBrown0)
 * [Refactor] [`boolean-prop-naming`]: invert if statement ([#3634][] @HenryBrown0)
 * [Refactor] [`function-component-definition`]: exit early if no type params ([#3634][] @HenryBrown0)
+* [Refactor] [`jsx-props-no-multi-spaces`]: extract type parameters to var ([#3634][] @HenryBrown0)
 
 [#3638]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3638
 [#3634]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3634
diff --git a/lib/rules/jsx-props-no-multi-spaces.js b/lib/rules/jsx-props-no-multi-spaces.js
@@ -98,8 +98,12 @@ module.exports = {
     }
 
     function containsGenericType(node) {
-      const containsTypeParams = typeof node.typeParameters !== 'undefined';
-      return containsTypeParams && node.typeParameters.type === 'TSTypeParameterInstantiation';
+      const nodeTypeParams = node.typeParameters;
+      if (typeof nodeTypeParams === 'undefined') {
+        return false;
+      }
+
+      return nodeTypeParams.type === 'TSTypeParameterInstantiation';
     }
 
     function getGenericNode(node) {

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,12 @@ module.exports = {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`function containsGenericType(node) {`
`101`		`- const containsTypeParams = typeof node.typeParameters !== 'undefined';`
`102`		`- return containsTypeParams && node.typeParameters.type === 'TSTypeParameterInstantiation';`
	`101`	`+ const nodeTypeParams = node.typeParameters;`
	`102`	`+ if (typeof nodeTypeParams === 'undefined') {`
	`103`	`+ return false;`
	`104`	`+ }`
	`105`	`+`
	`106`	`+ return nodeTypeParams.type === 'TSTypeParameterInstantiation';`
`103`	`107`	`}`
`104`	`108`
`105`	`109`	`function getGenericNode(node) {`