[New] Add attributes setting#979
Merged
ljharb merged 1 commit intojsx-eslint:mainfrom Sep 4, 2024
Merged
Conversation
ljharb
reviewed
Apr 15, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I might be a bit confused; i was suggesting only a setting, and no rule config changes at all.
Contributor
Author
|
Uh I am sorry, I thought it was a good idea to make the rule configurable too. I'll drop rule options, keeping the global setting. |
ljharb
force-pushed
the
attributes-setting
branch
from
ef13138 to
a1ee7f8
Compare
ljharb
approved these changes
Sep 4, 2024
This was referenced Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request replaces PR #977 and introduces a global setting to configure attributes, as suggested here.
It allows
forattribute support forlabel-has-associated-controlrule.Related: #894, fixes #961