New rule: prefer-tag-over-role#833
Conversation
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 99.27% 99.29% +0.01%
==========================================
Files 100 101 +1
Lines 1520 1553 +33
Branches 500 510 +10
==========================================
+ Hits 1509 1542 +33
Misses 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. |
jessebeach
left a comment
jessebeach
left a comment
There was a problem hiding this comment.
It's a good rule. Thank you for proposing it. I just have a few improvements that will use our utilities and provide more robustness.
jessebeach
left a comment
jessebeach
left a comment
There was a problem hiding this comment.
This is really close!! Just a few polishing tweaks to get it over the line! I think we'll be able to commit it after these few changes.
JoshuaKGoldberg
force-pushed
the
prefer-tag-over-role
branch
from
1ae1089 to
f86326f
Compare
jessebeach
left a comment
jessebeach
left a comment
There was a problem hiding this comment.
Thank you for the updates!
@ljharb looks good to ship!
|
There's still a little work to expose the rule through the plugin, but this is good enough to get the rule logic into the code. |
|
Thanks @JoshuaKGoldberg for proposing and writing this rule! |
|
Thanks for the helpful+informative reviews @jessebeach! And oops, I didn't think to add to the plugin rules & recommended sets. I can send a PR now. |
|
@JoshuaKGoldberg somehow we all totally missed the docs for this rule - could you send a PR to add them? |
3 participants
Fixes #101