Switch to export default syntax for exporting rules#819
Merged
ljharb merged 1 commit intojsx-eslint:masterfrom Oct 28, 2021
Merged
Switch to export default syntax for exporting rules#819ljharb merged 1 commit intojsx-eslint:masterfrom
export default syntax for exporting rules#819ljharb merged 1 commit intojsx-eslint:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
- Coverage 99.24% 99.22% -0.02%
==========================================
Files 98 98
Lines 1453 1417 -36
Branches 477 477
==========================================
- Hits 1442 1406 -36
Misses 11 11
Continue to review full report at Codecov.
|
Contributor
Author
|
Not so sure how this change could reduce code coverage. Maybe a flake? |
ljharb
force-pushed
the
export-default
branch
3 times, most recently
from
a3008d3 to
df34872
Compare
MichaelDeBoey
approved these changes
Oct 27, 2021
Member
ljharb
added a commit
that referenced
this pull request
Nov 10, 2021
Contributor
Author
|
@ljharb thanks for fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For module files (which
importstatements instead ofrequire), we might as well useexportstatements instead ofmodule.exportsto adopt fully modern syntax.As suggested in: #818 (comment)