Add eslint-plugin-eslint-plugin#818
Conversation
|
There’s no need to make eslintrc valid json; trailing commas and comments are a good feature. |
I agree those are good features. It's just a bit inconvenient to use those in JSON files since some IDEs will show syntax warnings. It's also confusing that the That's why I normally use the JS format of the config file Anyways, I reverted the changes to the original lines in |
bmish
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
c2ae0f3 to
efc2aaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 98 98
Lines 1417 1417
Branches 477 477
=======================================
Hits 1406 1406
Misses 11 11 Continue to review full report at Codecov.
|
ljharb
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
3c711de to
813b58e
Compare
ljharb
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
94a4684 to
f1414cf
Compare
3 participants
recommendedpractices for eslint rules and rule tests using eslint-plugin-eslint-plugin which is commonly used internally by eslint plugins.Exports rules usingexport defaultinstead ofmodule.exports =. Why?This is needed so thateslint-plugin-eslint-pluginwill recognize the rules sinceexport defaultis expected in files that usesourceType: module.For module files (whichimportstatements instead ofrequire), we might as well useexportstatements instead ofmodule.exportstoo to adopt fully modern syntax.