refactor: don't spread arrays#1034
Merged
ljharb merged 1 commit intojsx-eslint:mainfrom Oct 26, 2024
Merged
Conversation
Co-authored-by: v1rtl <[email protected]> Co-authored-by: Michaël De Boey <[email protected]>
MichaelDeBoey
force-pushed
the
dont-spread-arrays
branch
from
45f202c to
6d05681
Compare
ljharb
requested changes
Oct 25, 2024
MichaelDeBoey
force-pushed
the
dont-spread-arrays
branch
from
6d05681 to
8c1e3f2
Compare
Member
MichaelDeBoey
force-pushed
the
dont-spread-arrays
branch
2 times, most recently
from
3f72e2c to
be25c7c
Compare
Contributor
Author
That could cause errors as |
Member
|
This PR is about not spreading *-query arrays, though, not about destructuring builtins. |
Contributor
Author
|
Oops, I mixed them up as I was rebasing both PRs 🙈 Rebasing this to |
Member
|
No worries, I've done it :-) thanks! |
ljharb
force-pushed
the
dont-spread-arrays
branch
from
be25c7c to
d15d3ab
Compare
ljharb
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same reason as mentioned in #1030:
*.keys()&*.entries()is an array, so no need to spread them anymore