[Fix]: label-has-associated-control: ignore undetermined label text#1004
Merged
ljharb merged 1 commit intojsx-eslint:mainfrom Aug 22, 2024
Merged
[Fix]: label-has-associated-control: ignore undetermined label text#1004ljharb merged 1 commit intojsx-eslint:mainfrom
label-has-associated-control: ignore undetermined label text#1004ljharb merged 1 commit intojsx-eslint:mainfrom
Conversation
Fixes jsx-eslint#966 The rule no longer errors if the existence of label text cannot be determined
ljharb
approved these changes
Aug 22, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Seems good! I'll confirm the tests fail without the fix, and then merge.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 107 107
Lines 1660 1660
Branches 588 588
=======================================
Hits 1644 1644
Misses 16 16 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #966
The rule no longer errors if the existence of label text cannot be determined. The criteria for not being able to determine whether the text exists are, for each child of the label:
I don't think this accounts for every case, but hopefully a good starting point
I followed the convention already used by making the new parameters for
mayHaveAccessibleLabeloptional, even though they're not. I assume that was to make it easier to write the unit tests. Happy to change that though if you'd like