Skip to content

Issue 118 graph framing#438

Merged
gkellogg merged 3 commits into
masterfrom
issue-118-graph-framing
Nov 29, 2016
Merged

Issue 118 graph framing#438
gkellogg merged 3 commits into
masterfrom
issue-118-graph-framing

Conversation

@gkellogg

Copy link
Copy Markdown
Contributor

This PR closes #118, adding support for named graphs when framing, and allows framing to use either the merged graph or the default graph. It also adds an algorithm for creating the merged node set.

@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Nov 20, 2016
@gkellogg

Copy link
Copy Markdown
Contributor Author

See the formatted document for easier review.

@dlongley

Copy link
Copy Markdown
Member

I don't have much time to do a thorough review, but it's based off of the experimental work I was doing -- and making sure this supports the main use cases will require implementing it anyway. I support merging this PR.

The main case I'm concerned with is being able to produce a structure like this:

{
  "@context": "...",
  "id": "person1",
  "type": "IdentityProfile",
  "credential": [{
    "@graph": {
      "id": "cred1",
      "claim": {
        "id": "person1",
        "ageOver": 21
      },
      "signature": { ... }
    }, {
    "@graph": {    
      "id": "cred2",
      "claim": {
        "id": "person1",
        "passport": { ... },
      },
      "signature": { ... }
    }
  }]
}

This use case is about being able to receive an "IdentityProfile" in any format and then restructure it via framing for signature verification. The "IdentityProfile" consists of a set of credentials, each one containing verifiable claims about the subject of the IdentityProfile -- and the integrity of each must be preserved as an independent graph to enable proper verification of the signatures. Once the signatures have been checked, regular (merged) framing could also be used on this input to produce a utilitarian, merged view of the "person1" node containing all of the various properties from the verifiable claims.

@gkellogg

Copy link
Copy Markdown
Contributor Author

If you have some concrete input data and frame, we can add this as a test to make sure it works. Post a gist with some input and I can create a framing test for it.

@gkellogg
gkellogg merged commit a4985d9 into master Nov 29, 2016
@gkellogg
gkellogg deleted the issue-118-graph-framing branch November 29, 2016 16:55
@dlongley

Copy link
Copy Markdown
Member

@gkellogg -- I'll post a gist of some concrete input when I get a chance.

@gkellogg gkellogg modified the milestone: JSON-LD 1.1 Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How is @graph going to be used/supported in framing?

2 participants