Support underscore 1.7 and newer#332
Merged
schmunk42 merged 1 commit intojson-editor:masterfrom May 28, 2019
Merged
Conversation
Collaborator
Collaborator
I would say just support the latest version. |
Collaborator
|
Sorry for taking so long ... this is an optional dependency, right? |
Collaborator
It's one of the external template engines you can use. |
schmunk42
approved these changes
May 28, 2019
Collaborator
|
@phillip-tsui-avalara Do you have any schema examples that uses underscore templates, you could share? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underscore library made a breaking change with version 1.7.
_.template()now returns a function.https://underscorejs.org/#template