feat(route): list with kernel filtering#262
Merged
jsimonetti merged 1 commit intojsimonetti:masterfrom May 11, 2025
Merged
Conversation
A new "ListMatch" function has been added to the RouteService to allow for kernel-based filtering of the routing tables. The netlink flags required for getting a route for an IP (eg, rtnl.RouteGetAll) is different than those required while filtering the table. This changeset removes the superfluous "netlink.DumpFiltered" flag from the Get function of RouteService, as this flag is for kernel responses. Signed-off-by: Terin Stock <[email protected]>
terinjokes
force-pushed
the
routeservice-get
branch
from
a239502 to
a2cb3e7
Compare
terinjokes
changed the title
Owner
|
Sorry for the long delay in review. I was away on holiday. This lgtm. Nice addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new "ListMatch" function has been added to the RouteService to allow for kernel-based filtering of the routing tables. The netlink flags required for getting a route for an IP (eg, rtnl.RouteGetAll) is different than those required while filtering the table.
This changeset removes the superfluous "netlink.DumpFiltered" flag from the Get function of RouteService, as this flag is for kernel responses.