Skip to content

feat: implement support for altnames#241

Merged
jsimonetti merged 1 commit intojsimonetti:masterfrom
smira:feat/altnames
Dec 16, 2024
Merged

feat: implement support for altnames#241
jsimonetti merged 1 commit intojsimonetti:masterfrom
smira:feat/altnames

Conversation

@smira
Copy link
Copy Markdown
Contributor

@smira smira commented Dec 16, 2024

This properly list is used e.g. by systemd-udevd to provide other alternative names for predictable interface names.

This properly list is used e.g. by `systemd-udevd` to provide other
alternative names for predictable interface names.

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this pull request Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future.

Altnames are filled out by `systemd-udevd`.

This PR has two parts:

* show aliases & altnames in `LinkStatus`
* match links by aliases/altnames when we configure
  addresses/routes/links

This should make a transition to `systemd-udevd` less painful if the
previous link name is in `altNames`.

Forked rtnetlink for jsimonetti/rtnetlink#241

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this pull request Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future.

Altnames are filled out by `systemd-udevd`.

This PR has two parts:

* show aliases & altnames in `LinkStatus`
* match links by aliases/altnames when we configure
  addresses/routes/links

This should make a transition to `systemd-udevd` less painful if the
previous link name is in `altNames`.

Forked rtnetlink for jsimonetti/rtnetlink#241

Signed-off-by: Andrey Smirnov <[email protected]>
@jsimonetti
Copy link
Copy Markdown
Owner

LGTM
Thank you!

@jsimonetti jsimonetti merged commit ec4117e into jsimonetti:master Dec 16, 2024
smira added a commit to smira/talos that referenced this pull request Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future.

Altnames are filled out by `systemd-udevd`.

This PR has two parts:

* show aliases & altnames in `LinkStatus`
* match links by aliases/altnames when we configure
  addresses/routes/links

This should make a transition to `systemd-udevd` less painful if the
previous link name is in `altNames`.

Forked rtnetlink for jsimonetti/rtnetlink#241

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this pull request Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future.

Altnames are filled out by `systemd-udevd`.

This PR has two parts:

* show aliases & altnames in `LinkStatus`
* match links by aliases/altnames when we configure
  addresses/routes/links

This should make a transition to `systemd-udevd` less painful if the
previous link name is in `altNames`.

Forked rtnetlink for jsimonetti/rtnetlink#241

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this pull request Dec 17, 2024
At the moment, we don't use/support aliases, but we might in the future.

Altnames are filled out by `systemd-udevd`.

This PR has two parts:

* show aliases & altnames in `LinkStatus`
* match links by aliases/altnames when we configure
  addresses/routes/links

This should make a transition to `systemd-udevd` less painful if the
previous link name is in `altNames`.

Forked rtnetlink for jsimonetti/rtnetlink#241

Signed-off-by: Andrey Smirnov <[email protected]>
smira added a commit to smira/talos that referenced this pull request Dec 17, 2024
At the moment, we don't use/support aliases, but we might in the future.

Altnames are filled out by `systemd-udevd`.

This PR has two parts:

* show aliases & altnames in `LinkStatus`
* match links by aliases/altnames when we configure
  addresses/routes/links

This should make a transition to `systemd-udevd` less painful if the
previous link name is in `altNames`.

Forked rtnetlink for jsimonetti/rtnetlink#241

Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit 284ab11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants