rtnetlink: fix Link ListByKind response#233
Merged
jsimonetti merged 1 commit intojsimonetti:masterfrom Dec 17, 2024
Merged
Conversation
boussole
force-pushed
the
link_list_by_kind_fix
branch
from
25821ed to
585c357
Compare
boussole
force-pushed
the
link_list_by_kind_fix
branch
2 times, most recently
from
b4d1e0e to
466055d
Compare
Owner
|
Thank you for this contribution. |
boussole
force-pushed
the
link_list_by_kind_fix
branch
from
466055d to
38378ed
Compare
Contributor
Author
|
Yes, I added a simple test that shows a previous problem |
the linux kernel handles a RTM_GETLINK request even in case of incorrect kind filter. if it finds requested kind it responds with a list of this kind of links and marks every message in a response by NLM_F_DUMP_FILTERED flag. Otherwise it sends all available links w/o NLF_F_DUMP_FILTERED. So, looks much better to return to a callee empty link list if there are no links of requested kind. Signed-off-by: Andrey Grafin <[email protected]>
boussole
force-pushed
the
link_list_by_kind_fix
branch
from
38378ed to
c5984d2
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the linux kernel handles a RTM_GETLINK request even in case of incorrent kind filter. if it finds requested kind it responds with a list of this kind of links and marks every message in a response by NLM_F_DUMP_FILTERED flag. Otherwise it sends all available links w/o NLF_F_DUMP_FILTERED. So, looks much better to return to a callee empty link list if there are no links of requested kind.