v3: Remove node < 18 from CI matrix#118
Merged
wesleytodd merged 4 commits intojshttp:3.xfrom Aug 23, 2024
Merged
Conversation
Member
Author
|
Should the |
Contributor
Yes, especially them. They give trouble every so often I want them gone 100% in the next major lol |
Contributor
|
Just checking in as this is not forgotten. Will finalize once the Express versions are hammered down so we know this is usable in Express. |
Member
|
We have moved to drop up to node 18 for express. @broofa I pushed that change, as well as adding node 22 here. Also re-targeting this to a new 3.x branch. |
wesleytodd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting this up so we have something to look at for #115. Cutoff does not have to be at node@16. That's just where we'd draw the line in the world of
uuid.Maybe create a v3 branch / milestone for this and the
peerDependencychange (if/when that happens), and the mime-score PR (coming soon)?