ci: add nodejs v18 - v24 to test matrix #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillip9587
commented
Jun 19, 2025
Member
|
v23 is failing |
Contributor
Author
Please take a look at my comment |
…wer node versions
Contributor
Author
|
@bjohansebas @UlisesGascon Can you take another look? I updated the test to include a isError fallback for Node 23. The CI failures are just related to Coveralls current status: https://status.coveralls.io/incidents/fr6sp5kyn128 |
Contributor
Author
|
Hey @UlisesGascon can we merge this? I adressed all the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Node.js versions tested in the CI workflow to include newer releases.