fix: options.priority ternary in serialize validation#207
Merged
blakeembrey merged 1 commit intojshttp:masterfrom Nov 15, 2024
Merged
fix: options.priority ternary in serialize validation#207blakeembrey merged 1 commit intojshttp:masterfrom
blakeembrey merged 1 commit intojshttp:masterfrom
Conversation
Member
Author
|
Im guessing Codecov is failing bc I opened from a fork, so no access to the secret |
Member
|
Good catch, do you want to make both undefined in the ternaries? I don’t know why I didn’t do that the first time. |
Member
Author
|
By both you mean the next block w/ if (options.sameSite) {
const sameSite =
typeof options.sameSite === "string"
? options.sameSite.toLowerCase()
: options.sameSite;this needs to stay, at that part of the code sameSite can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #206
Assuming here this was not intentional