Conversation
|
Hi @dougwilson Any news? |
|
Oh, didn't realize there was another PR for this; I checked the original a few days ago. I will take a look at this one ASAP |
|
Hi @dougwilson, Any news? We already need this feature. |
|
@pazguille thank you for opening this PR. May I suggest adding the following to the readme as well, it is important for setting the Partitioned state It's probably worth adding some validations in the code if the Secure and Path properties are set correctly and throw some warning/error. I don't think it's a good idea to change the state of the cookie automatically. |
|
We don't do that with others flags like |
|
@dougwilson, makes sense. A disclaimer in the readme might be enough, stating that this library does not validate fields that partitioned depends on and this should be done on the client side. Once all browsers adapt a common standard (if ever), a validation can be added. |
|
Is this necessary for merge this PR? Please let me know. We need this to update our cookies. |
|
I'm not sure it is really necessary, no. Anyway, any objections for me landing this pr as is in lile 24 hours please let me know otherwise i plan to release it. |
|
@dougwilson are you ok with merging this PR and releasing it? We will then have to wait for express to adopt the change, at least in our case since we don't use the package directly, and that might take a while. Edit: I see you are also a maintainer of express, so hopefully the change will be adopted quickly :) |
|
@dougwilson, |
|
Sorry I was looking into getting the CI passing on the PR and life got in the way. I think I got it figured out though and should have it releaaed soon. Cannot merge a PR where the CI is failing. |
|
Hi @dougwilson |
|
They are all fixed now. I just need to rebasw and merge this when I get home, just ran out of time yesterday. |
188fd6e to
bcebc74
Compare
closes jshttp#147 closes jshttp#151 closes jshttp#153
@dougwilson I sent a complete PR for #151 🚀